Conversation
snewcomer
force-pushed
the
stripe_file_upload
branch
from
12c9d5d to
bb49b22
Compare
joshsmith
reviewed
Dec 12, 2016
|
|
||
| @invalid_attrs %{} | ||
|
|
||
| describe "create_changeset/2" do |
Contributor
There was a problem hiding this comment.
Would change to create_identity_document_changeset/2
Contributor
|
@snewcomer I think no |
joshsmith
reviewed
Dec 12, 2016
web/models/stripe_file_upload.ex
Outdated
| field :purpose, :string | ||
| field :url, :string | ||
| field :type, :string | ||
| field :id_from_stripe, :string, null: false |
Contributor
There was a problem hiding this comment.
Would reorder by alpha here (and again down in the cast
snewcomer
force-pushed
the
stripe_file_upload
branch
from
bb49b22 to
4abb92b
Compare
joshsmith
reviewed
Dec 12, 2016
| add :size, :integer | ||
| add :type, :string | ||
| add :url, :string | ||
| end |
Contributor
There was a problem hiding this comment.
Not sure I see the stripe_connect_account in here.
Contributor
Author
There was a problem hiding this comment.
Would it look like this? add :stripe_connect_account_id, references(:stripe_connect_accounts) or add :stripe_connect_account_id, references(:stripe_connect_accounts, on_delete: nothing)
Contributor
Author
There was a problem hiding this comment.
@joshsmith ah sry. on_delete is defaulted to nothing.
snewcomer
force-pushed
the
stripe_file_upload
branch
from
4abb92b to
782708e
Compare
joshsmith
approved these changes
Dec 14, 2016
joshsmith
force-pushed
the
stripe_file_upload
branch
from
782708e to
ae132db
Compare
Contributor
|
🙌 great work @snewcomer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
StripeFileUpload model
Do we need a create_changeset function as well?